Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal API - Create spec from variables #1303

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Internal API - Create spec from variables #1303

merged 2 commits into from
Nov 26, 2024
+57 −1

Conversation

oshratZairi
Copy link
Contributor

@oshratZairi oshratZairi commented Nov 19, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Adding a function to create a spec from provided parameters

@lesnerd lesnerd requested review from eyalbe4 and RobiNino November 19, 2024 11:18
@lesnerd lesnerd added the improvement Automatically generated release notes label Nov 19, 2024
@oshratZairi oshratZairi force-pushed the createSpecFromVariables branch from 534f258 to d534105 Compare November 19, 2024 13:34
eyalbe4
eyalbe4 requested changes Nov 21, 2024
View reviewed changes
common/spec/specfiles.go Outdated Show resolved Hide resolved
@oshratZairi oshratZairi force-pushed the createSpecFromVariables branch from d534105 to 1a0e145 Compare November 24, 2024 07:51
@oshratZairi oshratZairi force-pushed the createSpecFromVariables branch from 1a0e145 to 82d5deb Compare November 24, 2024 10:02
eyalbe4
eyalbe4 requested changes Nov 25, 2024
View reviewed changes
common/spec/specfiles_test.go Outdated Show resolved Hide resolved
@oshratZairi oshratZairi force-pushed the createSpecFromVariables branch from 5374634 to 6e0f244 Compare November 26, 2024 08:00
@eyalbe4 eyalbe4 merged commit e16bd86 into jfrog:dev Nov 26, 2024
6 of 7 checks passed
@eyalbe4 eyalbe4 changed the title Create spec from variables Internal API - Create spec from variables Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshratZairi @eyalbe4 @lesnerd